Feat/scmi 124971 [Domain models initiative] is empty method lint rule#1792
Open
aleixadevinta wants to merge 2 commits intomasterfrom
Open
Feat/scmi 124971 [Domain models initiative] is empty method lint rule#1792aleixadevinta wants to merge 2 commits intomasterfrom
aleixadevinta wants to merge 2 commits intomasterfrom
Conversation
aleixadevinta
requested review from
andresz1,
carlosvillu,
kikoruiz and
sui-bot
as code owners
aleixadevinta
changed the title
kikoruiz
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this pull request we ensure that a doamin model class (value object or entity) has all attributes as private and each attribute has his getter.
Related Issue
SCMI-124971