feat:added responsiveness#8
feat:added responsiveness#8Arjit1136 wants to merge 2 commits intoSamagra-Development:c4gt-communityfrom
Conversation
techsavvyash
left a comment
techsavvyash
left a comment
There was a problem hiding this comment.
Please all add screen recordings/screenshots showing the responsive behaviour.
src/pages/Login.tsx
Outdated
| }} | ||
| > | ||
| Login to get the courses | ||
| {/* Login to get the courses */} |
There was a problem hiding this comment.
Why is this text line commented?
src/pages/Login.tsx
Outdated
| <Col xs={12} md={6}> | ||
| <Container | ||
| className="login-form" | ||
| style={{ |
There was a problem hiding this comment.
can we move these inline styles to a dedicated css file?
|
@techsavvyash I have made the requested changes. |
|
Hey @Arjit1136, |
|
Also, I have changed the target branch for your PR, please rebase in your fork and make sure everything is working as intended. |
| e.preventDefault(); | ||
|
|
||
| const url = `https://auth.konnect.samagra.io/api/login`; |
There was a problem hiding this comment.
can you move this url to env file ?
|
|
||
| const handleAnonymously=useCallback(()=>{ | ||
| const handleAnonymously = useCallback(() => { | ||
| props.socket.emit("search", filters); |
There was a problem hiding this comment.
add optional chaining like props?.socket?.emit
| }, []); | ||
|
|
||
| console.log("mnop:",{filters}) | ||
| console.log("mnop:", { filters }); |
There was a problem hiding this comment.
plz remove the consoles
| <Row> | ||
| <Col> | ||
| <p | ||
| style={{ |
There was a problem hiding this comment.
I prefer to not use inline styling, can you use className for it ?
3 participants
Changes :
Screenshots :