Open
Conversation
Author
|
I guess the README's "A word on dotted keys" may need updating, if you merge this update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code in WriteValueToStringBuilder called GetValue(subKey) to re-fetch the value. But GetValue uses TomlKeyUtils.GetTopLevelAndSubKeys which interprets periods as nested table separators. This meant dictionary keys like "key.with.dots" would fail because it tried to find a subtable instead of a flat key.
The workaround (commit 75d5c8f): The author added . to the valid bare key characters as a quick fix. But this was incorrect per the TOML spec and just happened to work because keys with periods wouldn't get quoted, then the code would "find" them via the dotted key logic.
The proper fix:
Why underscore and dash are still valid: The TOML spec explicitly allows them in bare keys: "Bare keys may only contain ASCII letters, ASCII digits, underscores, and dashes (A-Za-z0-9_-)."