Skip to content

Added time-based greetings#752

Open
Sanket2004 wants to merge 1 commit intoSauravMukherjee44:mainfrom
Sanket2004:time-based-greeting
Open

Added time-based greetings#752
Sanket2004 wants to merge 1 commit intoSauravMukherjee44:mainfrom
Sanket2004:time-based-greeting

Conversation

@Sanket2004
Copy link
Contributor

🛠️ Fixes Issue

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Screenshot_20221027_165441
Time-based greeting added.

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for codeincommunity ready!

Name Link
🔨 Latest commit 5fa7eeb
🔍 Latest deploy log https://app.netlify.com/sites/codeincommunity/deploys/635a6b02072b260008b5d7f1
😎 Deploy Preview https://deploy-preview-752--codeincommunity.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Naresh-chandanbatve Naresh-chandanbatve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove demo text
it looks bad when the page is loading
keep it blank until the greeting loads.

@Sanket2004
Copy link
Contributor Author

You should remove demo text it looks bad when the page is loading keep it blank until the greeting loads.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants