Skip to content

Remove unsupported tag property from build-release gh workflow#401

Merged
omkar-ethz merged 1 commit intodevelopfrom
gh-wf-fix
Aug 5, 2025
Merged

Remove unsupported tag property from build-release gh workflow#401
omkar-ethz merged 1 commit intodevelopfrom
gh-wf-fix

Conversation

@omkar-ethz
Copy link
Member

Description

As per the docs, the tags property is not present on the release event. I suspect this is blocking the workflow from running on a new release (e.g. v3.4 - however the build-release workflow wasn't run)

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?

Extra Information/Screenshots

Copy link
Member

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In case this does not work, I believe this will

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a GitHub Actions workflow configuration by removing an unsupported tags property from the release event trigger. The GitHub Actions release event does not support a tags property, which was likely preventing the build-release workflow from executing when new releases are created.

  • Removes the invalid tags property from the release event trigger
  • Maintains the types: created configuration to trigger on release creation

@omkar-ethz
Copy link
Member Author

LGTM. In case this does not work, I believe this will

Oh, thanks! will give this fix a shot by re-triggering the release somehow

@omkar-ethz omkar-ethz merged commit 76d028d into develop Aug 5, 2025
7 checks passed
@omkar-ethz omkar-ethz deleted the gh-wf-fix branch August 5, 2025 09:27
@omkar-ethz
Copy link
Member Author

This seemed to have worked! recreated the v3.4 release and resulted in a workflow run: https://github.com/SciCatProject/LandingPageServer/actions/runs/16746398347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants