Manage linters with pre-commit instead of uv #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
approved these changes
Feb 5, 2026
Collaborator
YooSunYoung
left a comment
YooSunYoung
left a comment
There was a problem hiding this comment.
It looks good to me!
I only had some minor comments/typo fix suggestions.
| "specfield", | ||
| "socio-economic", | ||
| ] | ||
| skip = "build,docs/generated,html" |
Collaborator
There was a problem hiding this comment.
Are they excluded automatically becuase they are in .gitignore?
Collaborator
Author
There was a problem hiding this comment.
No, I removed this because I switched from 'codespell' to 'typos' because the latter has better support for identifiers. Should have made that more clear in the PR description.
|
|
||
| prek auto-update | ||
|
|
||
| Note that an earlier version implemented linters and formatters in ``justfile`` with ``uv run ...`` |
Collaborator
There was a problem hiding this comment.
I think this part is worth wrapped as an admonitions
YooSunYoung
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added section in the dev docs explains what is going on here and why. But the TL;DR is, I could not make commits with pycharm because it couldn't find just on my PATH and so the hooks failed. This setup works. Plus, it seems to be more robust in general.
This PR also switches from 'codespell' to 'typos'.