changed the directory structure of the generated entity files#2751
Open
kev1N916 wants to merge 1 commit intoSeaQL:masterfrom
Open
changed the directory structure of the generated entity files#2751kev1N916 wants to merge 1 commit intoSeaQL:masterfrom
kev1N916 wants to merge 1 commit intoSeaQL:masterfrom
Conversation
Member
|
I think we should add a new flag and set the previous one as the default value. |
Author
|
@Huliiiiii I've added a new flag. |
Huliiiiii
reviewed
Oct 13, 2025
| default_value = "false", | ||
| help = "Use the new directory structure when generating the entity files." | ||
| )] | ||
| use_new_dir_structure: bool, |
Member
There was a problem hiding this comment.
Some alternatives:
- (use_)new_module_(style/structure/layout): bool
- module_(style/structure/layout): (old, 2018)
@tyt2y3 What do you think?
Huliiiiii
requested changes
Oct 13, 2025
Signed-off-by: involk-secure-1609 <kevintj916@gmail.com>
Member
|
I think this is a good idea, although we need to provide a flag for compatiblity and fix the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Closes #2690
New Features
Changes the directory structure of the generated entitity files.