Allows support for postgres:db_name format#2754
Open
kev1N916 wants to merge 1 commit intoSeaQL:masterfrom
Open
Allows support for postgres:db_name format#2754kev1N916 wants to merge 1 commit intoSeaQL:masterfrom
kev1N916 wants to merge 1 commit intoSeaQL:masterfrom
Conversation
Signed-off-by: involk-secure-1609 <kevintj916@gmail.com>
kev1N916
changed the title
Huliiiiii
requested changes
Oct 13, 2025
| }) | ||
| .next() | ||
| .unwrap(); | ||
| let database_name = match url.path_segments() { |
Member
There was a problem hiding this comment.
Could you move this logic into a separate function and write a unit test to ensure we get the correct database name?
Member
There was a problem hiding this comment.
If unit tests for this already exist, please let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Closes #2647
Bug Fixes
Fixes the bug where we are not able to connect to the postgres database when the url is given in the postgres:db_name format.