Open
Conversation
corevo
requested changes
Apr 7, 2019
Member
corevo
left a comment
There was a problem hiding this comment.
We are using yarn how is it that a package-lock.json was generated, please remove it and make sure to squash so it won't be in the history.
Contributor
Author
|
@corevo oh, weird. Squashed it down to one commit for easier viewing. |
corevo
requested changes
Apr 28, 2019
Member
corevo
left a comment
There was a problem hiding this comment.
Hey, great work but there are a few experience improvements that are needed
- drag n drop for the entire selection
- holding down the primary modifier (ctrl for windows command for mac) should be additive to the selected commands, currently it has no effect (look at modifier keys to see how we handle it cross os)
- only the last selected command should have the top border (it is used to denote where commands will be inserted when recording)
Thanks a lot for the work put into this, this looks great so far!
|
david califf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be happy to port this to the electron app as well.
Credit to @Jongkeun for initial legwork.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement