Add mountNode prop to Popup module#4362
Open
svicalifornia wants to merge 1 commit intoSemantic-Org:masterfrom
Open
Add mountNode prop to Popup module#4362svicalifornia wants to merge 1 commit intoSemantic-Org:masterfrom
svicalifornia wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
If a React app with SUIR is running in a hidden IFRAME and rendering some or all of its virtual DOM to the parent frame or another frame, then the Popup component should not insert popup elements into the document.body of the React IFRAME, but instead should inject into the frame containing the Popup trigger, or even into some other container as may be more appropriate (due to size or layering concerns between multiple frames). Adding a `mountNode` prop to Popup allows developers to specify the appropriate container for a displayed popup element in cases such as the above example.
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #4362 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3248 3250 +2
=======================================
+ Hits 3240 3242 +2
Misses 8 8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a React app with SUIR is running in a hidden IFRAME and rendering some or all of its virtual DOM to the parent frame or another frame, then the Popup component should not insert popup elements into the document.body of the React IFRAME, but instead should inject into the frame containing the Popup trigger, or even into some other container as may be more appropriate (due to size or layering concerns between multiple frames).
Adding a
mountNodeprop to Popup allows developers to specify the appropriate container for a displayed popup element in cases such as the above example.This PR implements a
mountNodeprop for Popup, with code very similar to the same prop's implementation in Modal.