Integration github-upload with the rest of the app#35
Open
batunpc wants to merge 4 commits intoSeneca-CDOT:mainfrom
Open
Integration github-upload with the rest of the app#35batunpc wants to merge 4 commits intoSeneca-CDOT:mainfrom
github-upload with the rest of the app#35batunpc wants to merge 4 commits intoSeneca-CDOT:mainfrom
Conversation
humphd
requested changes
Dec 9, 2022
Collaborator
Author
|
Thank you for your comments @humphd please let me know if I should do any other change for this PR I have filed follow-up issue regarding your comment, and will be raising PR soon. |
This was referenced Dec 10, 2022
humphd
requested changes
Dec 14, 2022
Collaborator
humphd
left a comment
humphd
left a comment
There was a problem hiding this comment.
Looks good, one minor thing.
Collaborator
Author
|
Thank you @humphd I have implemented the suggested change 👍 |
SerpentBytes
approved these changes
Dec 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
As discussed in the issue, current behavior of the app is completely isolated from
github-uploadfunction usingOctokit. Which was implemented at #11This PR integrates the "upload images to authenticated repo using
github-upload" functionality into the front-end, as it was programmatically written for client side.Steps to reproduce
First create an public repository with the desired name.
Next, navigate to Settings > Developer settings > PAT > Tokens(Classic) to create a
brand-new token.Ensure you have provided PAT permission to the created repository from step 1.
After token is created you can start the app with
npm run startand follow the rest of the steps. After you have uploaded an supported type image and click onupload, you will seerawdirectory within the repo you have created.It will look something like this.