[CI] try to split up example gallery gen#1649
[CI] try to split up example gallery gen#1649tdavidcl wants to merge 22 commits intoShamrock-code:mainfrom
Conversation
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Summary of ChangesHello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new utility script aimed at streamlining the Sphinx documentation generation process, specifically for individual examples. This change provides a more granular and potentially more efficient way to build documentation, which could be beneficial for continuous integration workflows or focused development efforts. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new script to generate documentation for a single example, which is useful for splitting up the documentation build in CI. My review focuses on improving the robustness and efficiency of this new bash script. I've suggested changes to:
- Add a missing check for the required script argument.
- Improve the Python dependency installation logic to be more efficient and reliable.
- Make the Python command detection more robust to handle systems with either
pythonorpython3.
These changes will make the script more reliable and maintainable.
Workflow reportworkflow report corresponding to commit ab97467 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
No description provided.