Skip to content

[CI] try to split up example gallery gen#1649

Draft
tdavidcl wants to merge 22 commits intoShamrock-code:mainfrom
tdavidcl:patch-2026-02-15-12-48
Draft

[CI] try to split up example gallery gen#1649
tdavidcl wants to merge 22 commits intoShamrock-code:mainfrom
tdavidcl:patch-2026-02-15-12-48

Conversation

@tdavidcl
Copy link
Member

No description provided.

@tdavidcl tdavidcl added the draft label Feb 15, 2026
@github-actions
Copy link
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@gemini-code-assist
Copy link

Summary of Changes

Hello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new utility script aimed at streamlining the Sphinx documentation generation process, specifically for individual examples. This change provides a more granular and potentially more efficient way to build documentation, which could be beneficial for continuous integration workflows or focused development efforts.

Highlights

  • New Sphinx example generation script: Introduced doc/sphinx/gen_sphinx_doc_single_example.sh, a new shell script designed to generate Sphinx documentation for a single specified example file.
  • Dependency management: The script includes checks for Python and the shamrock library, and automatically installs necessary Python packages like sphinx, sphinx-gallery, and matplotlib if they are not already present.
  • Targeted documentation build: It leverages make html with SPHINXOPTS to configure sphinx_gallery_conf.filename_pattern, allowing the documentation build to focus exclusively on the provided example.
Changelog
  • doc/sphinx/gen_sphinx_doc_single_example.sh
    • Added a new shell script to generate Sphinx documentation for a single example file.
    • Implemented checks for Python and shamrock installation.
    • Included logic to install required Python packages via pip.
    • Configured Sphinx build to target a specific example using SPHINXOPTS.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/shamrock-acpp-phys-test.yml
Activity
  • No specific activity (comments, reviews, progress) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script to generate documentation for a single example, which is useful for splitting up the documentation build in CI. My review focuses on improving the robustness and efficiency of this new bash script. I've suggested changes to:

  1. Add a missing check for the required script argument.
  2. Improve the Python dependency installation logic to be more efficient and reliable.
  3. Make the Python command detection more robust to handle systems with either python or python3.

These changes will make the script more reliable and maintainable.

@github-actions
Copy link
Contributor

Workflow report

workflow report corresponding to commit ab97467
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 8135 → 8135 (0.0%)

Detailed changes :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant