Skip to content

Suggestion to delete entire timetable when user starts to delete the timetable#2134

Merged
nilsreichardt merged 5 commits intomainfrom
codex/delete-entire-timetable
Feb 7, 2026
Merged

Suggestion to delete entire timetable when user starts to delete the timetable#2134
nilsreichardt merged 5 commits intomainfrom
codex/delete-entire-timetable

Conversation

@nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Feb 3, 2026

DeleteAllLessons.mp4

@nilsreichardt nilsreichardt added the codex Used for PRs that are generated by Codex. label Feb 3, 2026
@github-actions github-actions bot added feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing labels Feb 3, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful feature that suggests deleting the entire timetable when a user deletes multiple lessons in a short time. It also adds the necessary backend logic to delete lessons in batches and includes a confirmation dialog with a countdown for safety. The implementation is solid, and the addition of tests is great. I have a couple of suggestions regarding a style guide violation and a potential bug in one of the test mocks.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Visit the preview URL for this PR (updated for commit d2a6bfd):

https://sharezone-website-dev--pr2134-codex-delete-entire-k5z5tlm0.web.app

(expires Tue, 10 Feb 2026 22:29:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Visit the preview URL for this PR (updated for commit e3b4b99):

https://sharezone-console-dev--pr2134-codex-delete-entire-o3vk6gy1.web.app

(expires Tue, 10 Feb 2026 23:08:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Visit the preview URL for this PR (updated for commit e3b4b99):

https://sharezone-test--pr2134-codex-delete-entire-nlo37f7z.web.app

(expires Tue, 10 Feb 2026 23:09:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt merged commit 7a25b05 into main Feb 7, 2026
42 of 43 checks passed
@nilsreichardt nilsreichardt deleted the codex/delete-entire-timetable branch February 7, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Used for PRs that are generated by Codex. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant