Split format function and null formats#90
Open
andreyea wants to merge 2 commits intoSheetJS:masterfrom
Open
Conversation
Allow special characters inside double quotes.
If fmt.length is 0, treat the format as a single space. Format string example: #,###;;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows specials characters (; \ * ) to be inside double quotes in format definition. For example, "***";"*_".
If a format string is defined as #,###;; (return formatted value for positives and return empty string for negatives and zeroes), it will treat all null definitions as a single space. This is a valid format in Excel.
This also covers issue SheetJS/sheetjs#2569