-
Notifications
You must be signed in to change notification settings - Fork 226
make new package for app execute #6587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18e3efd to
5a2ca96
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Coverage report
Show new covered files 🐣
Test suite run success3358 tests passing in 1372 suites. Report generated by 🧪jest coverage report action from 53131b7 |
5a2ca96 to
f71b978
Compare
jordanverasamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good, just some Qs
58cd95b to
74280ce
Compare
74280ce to
53131b7
Compare
jordanverasamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice changes ty :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still looks good :P
| body: 'Placeholder command. Add execution logic here.', | ||
| }) | ||
|
|
||
| return {app: undefined as unknown as AppInterface} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing context on what this execute command is intended to do, but scaffolding looks good! Asking about the command intention, because that will change your app return value, ie AppUnlinkedCommand or AppLinkedCommand. Regardless, since it should be run within the context of an app (whether thats authenticated or not), you can probably just return the actual resolved app for now.
| return {app: undefined as unknown as AppInterface} | |
| const {flags} = await this.parse(Build) | |
| // ... | |
| const app = await localAppContext({ | |
| directory: flags.path, | |
| userProvidedConfigName: flags.config, | |
| }) | |
| // ... | |
| return {app} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The execute command is basically doing this. But thanks for the feedback, will keep that in mind!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be AppLinkedCommand and the app should be obtained using linkedAppContext (as most other commands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I realized this in my next PR! Will fix this then.
alexanderMontague
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scaffolding looks good, and thanks for making it hidden!

Resolves: https://github.com/shop/issues-api-foundations/issues/1064
Background
Creating the new
shopify app executeCLI command.This is just the bare bones outline of the CLI command that is basically empty. We will be implementing the command logic into this.
To Test
Use
pnpm shopify app executeto test commands during development. This builds and runs the CLI from source without needing to install it globally.Why regenerate the manifest:
I had to run the
pnpm refresh-manifestscommand to regenerate the manifest. This is because:What it added: