Remove legacy app schema #6612

gonzaloriestra · 2025-11-12T13:09:20Z

WHY are these changes introduced?

We have a lot of code to support legacy and new app schemas, and it's time to remove the legacy one.

⚠️ These PRs for the templates must be merged first (the acceptance tests will pass then):

The subscriptions-reference-app template is ready, and I guess there's no need to update old templates like Node, Ruby or PHP.

WHAT is this pull request doing?

Make client_id required in app schema (templates must include client_id = "")
Remove support for legacy scopes field at root level - now requires [access_scopes] section
Simplify the code to only support the new schema

How to test your changes?

pnpm shopify app init --template=https://github.com/Shopify/shopify-app-template-react-router#add-client-id-to-toml
pnpm shopify app init --template=https://github.com/Shopify/shopify-app-template-none#add-client-id-to-toml
pnpm shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#add-client-id-to-toml
pnpm shopify app init --template https://github.com/Shopify/shopify-app-template-react-router#include-declarative-definition (related to Support flexible templates for app init #6751)

Measuring impact

How do we know this change was effective? Please choose one:

n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes

github-actions · 2025-11-12T13:23:06Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	79.64% (+0.41% 🔼)	14404/18086
🟡	Branches	74.02% (+0.92% 🔼)	7133/9636
🟡	Functions	79.78% (+0.41% 🔼)	3681/4614
🟡	Lines	79.99% (+0.41% 🔼)	13618/17025

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / admin-as-app.ts	100%	100%	100%	100%
🟢	`...` / metafield_definitions.ts	100%	100%	100%	100%
🟢	`...` / metaobject_definitions.ts	100%	100%	100%	100%
🟢	`...` / bulk-operation-cancel.ts	100%	100%	100%	100%
🟢	`...` / bulk-operation-run-mutation.ts	100%	100%	100%	100%
🟢	`...` / bulk-operation-run-query.ts	100%	100%	100%	100%
🟢	`...` / get-bulk-operation-by-id.ts	100%	100%	100%	100%
🟢	`...` / list-bulk-operations.ts	100%	100%	100%	100%
🟢	`...` / staged-uploads-create.ts	100%	100%	100%	100%
🟢	`...` / fetch_store_by_domain.ts	100%	100%	100%	100%
🟢	`...` / organization_exp_flags.ts	100%	100%	100%	100%
🔴	`...` / import-custom-data-definitions.ts	0%	100%	0%	0%
🔴	`...` / cancel.ts	0%	100%	0%	0%
🔴	`...` / execute.ts	0%	0%	0%	0%
🔴	`...` / status.ts	0%	0%	0%	0%
🔴	`...` / pull.ts	0%	100%	0%	0%
🟡	`...` / execute-operation.ts	75.68%	50%	100%	75.68%
🔴	`...` / pull.ts	0%	0%	0%	0%
🟢	`...` / bulk-operation-status.ts	96.55%	92.11%	100%	100%
🟢	`...` / cancel-bulk-operation.ts	100%	100%	100%	100%
🟢	`...` / constants.ts	100%	100%	100%	100%
🟢	`...` / download-bulk-operation-results.ts	100%	100%	100%	100%
🟢	`...` / execute-bulk-operation.ts	87.14%	83.67%	100%	88.41%
🟢	`...` / format-bulk-operation-status.ts	100%	100%	100%	100%
🟢	`...` / run-mutation.ts	100%	100%	100%	100%
🟢	`...` / run-query.ts	100%	100%	100%	100%
🟡	`...` / stage-file.ts	73.53%	62.5%	85.71%	72.73%
🟢	`...` / watch-bulk-operation.ts	100%	94.74%	100%	100%
🟢	`...` / utilities.ts	100%	100%	100%	100%
🟢	`...` / declarative-definitions.ts	98.54%	93.18%	100%	98.51%
🟢	`...` / common.ts	97.62%	95%	100%	97.06%
🟢	`...` / execute-command-helpers.ts	100%	100%	100%	100%
🟢	`...` / file-formatter.ts	100%	100%	100%	100%
🔴	`...` / promiseWithResolvers.ts	33.33%	50%	50%	33.33%
🟢	`...` / theme-listing.ts	100%	100%	100%	100%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / execute.ts	0%	0% (-100% 🔻)	0%	0%
🟢	`...` / app.test-data.ts	91.88% (-0.16% 🔻)	94.59% (+0.68% 🔼)	82.35% (-0.21% 🔻)	91.26% (-0.19% 🔻)
🟢	`...` / app.ts	88.02% (+1.39% 🔼)	68.97% (+0.39% 🔼)	93.33% (-0.32% 🔻)	88.59% (+0.25% 🔼)
🟢	`...` / loader.ts	93.9% (+0.04% 🔼)	85.86% (-0.97% 🔻)	97.22% (+0.16% 🔼)	94.15% (-0.52% 🔻)
🟢	`...` / extension-instance.ts	84.8% (+0.23% 🔼)	78.4% (-0.11% 🔻)	92.06% (+0.13% 🔼)	85.11% (+0.24% 🔼)
🟡	`...` / specification.ts	69.64% (+0.55% 🔼)	75.61% (+2.44% 🔼)	76.47% (-1.31% 🔻)	69.39% (+0.64% 🔼)
🟢	`...` / ui_extension.ts	88.61% (-6.22% 🔻)	78.57% (-2.68% 🔻)	85.19% (-14.81% 🔻)	90.79% (-5.67% 🔻)
🟢	`...` / common.ts	87.5% (-12.5% 🔻)	88.89% (-11.11% 🔻)	100%	100%
🟢	`...` / app-context.ts	96.55% (-0.11% 🔻)	89.47% (-1.83% 🔻)	100%	96.43% (-0.12% 🔻)
🔴	`...` / dev.ts	16.54% (-0.65% 🔻)	16.44% (-0.89% 🔻)	19.44%	16.95% (-0.7% 🔻)
🟢	`...` / store-context.ts	100%	82.35% (-0.98% 🔻)	100%	100%
🟢	`...` / Logs.tsx	90%	90.91% (-5.97% 🔻)	100%	90%
🟢	`...` / link.ts	96.39% (-0.13% 🔻)	95.38% (-0.07% 🔻)	100%	96.2% (-0.14% 🔻)
🟢	`...` / fetch.ts	84.21% (+0.88% 🔼)	82.35% (-0.98% 🔻)	75%	85.29% (+1.42% 🔼)
🟢	`...` / app-event-watcher-handler.ts	86.36% (-4.11% 🔻)	75%	86.67%	85.71% (-5.19% 🔻)
🟡	`...` / middlewares.ts	77.33% (-0.87% 🔻)	75%	68.42% (-1.58% 🔻)	76.39% (-0.94% 🔻)
🔴	`...` / server.ts	1.23% (-0.02% 🔻)	0%	0%	1.3% (-0.02% 🔻)
🟢	`...` / setup-dev-processes.ts	93.62% (+0.14% 🔼)	66.67% (-4.76% 🔻)	90%	92.86% (+0.17% 🔼)
🟢	`...` / bundle.ts	93.22%	63.33% (-3.33% 🔻)	94.12% (+5.88% 🔼)	96.3%
🟢	`...` / developer-platform-client.ts	84.62% (-1.5% 🔻)	71.43% (+0.84% 🔼)	81.82% (+1.82% 🔼)	93.75% (+0.42% 🔼)
🔴	`...` / http-reverse-proxy.ts	58.97% (-4.91% 🔻)	37.04% (-2.96% 🔻)	58.33% (-5.3% 🔻)	59.46% (-5.25% 🔻)
🟢	`...` / api.ts	87.07% (-0.43% 🔻)	76.71% (-0.1% 🔻)	100%	86.49% (-0.43% 🔻)
🟢	`...` / device-authorization.ts	88.24% (-0.83% 🔻)	76.47% (-2.94% 🔻)	100%	88.24% (-0.83% 🔻)
🟢	`...` / ConcurrentOutput.tsx	98.36% (-1.64% 🔻)	92% (-4% 🔻)	100%	98.33% (-1.67% 🔻)
🟢	`...` / SingleTask.tsx	84.21% (-15.79% 🔻)	50% (-50% 🔻)	80% (-20% 🔻)	84.21% (-15.79% 🔻)
🟢	`...` / string.ts	94.44% (-0.47% 🔻)	84.38% (+1.04% 🔼)	96.15% (+0.5% 🔼)	96.72% (+0.64% 🔼)
🔴	`...` / environment.ts	35% (-5% 🔻)	41.18%	40% (-10% 🔻)	36.84% (-5.26% 🔻)
🔴	`...` / ui.tsx	50.82% (-0.79% 🔻)	42.86% (-5.53% 🔻)	54.55% (+1.42% 🔼)	50% (-0.82% 🔻)
🟢	`...` / console.ts	81.82% (+15.15% 🔼)	75% (-25% 🔻)	100% (+33.33% 🔼)	81.82% (+15.15% 🔼)
🟢	`...` / init.ts	88% (-0.89% 🔻)	71.43% (+4.76% 🔼)	86.67% (+4.85% 🔼)	88% (-0.89% 🔻)
🟢	`...` / storefront-renderer.ts	90.2% (-0.54% 🔻)	78.95%	81.82% (-1.52% 🔻)	90.2% (-0.54% 🔻)
🟡	`...` / theme-polling.ts	67.57% (-0.49% 🔻)	68.75%	78.57%	66.18% (-1.47% 🔻)

Test suite run success

3691 tests passing in 1434 suites.

Report generated by 🧪jest coverage report action from 48c5296

github-actions · 2025-12-19T03:50:47Z

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

gonzaloriestra · 2026-02-04T15:30:06Z

/snapit

github-actions · 2026-02-04T15:33:10Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260204153101

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

gonzaloriestra force-pushed the remove-legacy-schema branch from a720cd9 to dbb7bd3 Compare November 12, 2025 13:17

gonzaloriestra force-pushed the remove-legacy-schema branch from dbb7bd3 to 3cc6b58 Compare November 12, 2025 13:56

gonzaloriestra changed the title ~~Remove legacy schema~~ Remove legacy app schema Nov 17, 2025

github-actions bot added the no-pr-activity label Dec 19, 2025

github-actions bot closed this Dec 26, 2025

gonzaloriestra reopened this Jan 12, 2026

gonzaloriestra added stale-exempt If added, the PR/issue won't be closed by stale-bot and removed no-pr-activity labels Jan 12, 2026

gonzaloriestra force-pushed the remove-legacy-schema branch from 3cc6b58 to 28c8da5 Compare January 12, 2026 11:52

gonzaloriestra mentioned this pull request Jan 12, 2026

Support flexible templates for app init #6751

Merged

5 tasks

gonzaloriestra force-pushed the remove-legacy-schema branch from 28c8da5 to 1ff8979 Compare January 12, 2026 12:02

gonzaloriestra force-pushed the remove-legacy-schema branch 4 times, most recently from 7b00e6c to 2c41f40 Compare February 4, 2026 13:51

Remove legacy schema

48c5296

gonzaloriestra force-pushed the remove-legacy-schema branch from 2c41f40 to 48c5296 Compare February 4, 2026 15:20

This was referenced Feb 4, 2026

Update the TOML schema Shopify/shopify-app-template-react-router#127

Draft

Update the TOML schema Shopify/shopify-app-template-remix#1224

Draft

Update the TOML schema Shopify/shopify-app-template-none#24

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy app schema #6612

Remove legacy app schema #6612

Uh oh!

gonzaloriestra commented Nov 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

gonzaloriestra commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Remove legacy app schema #6612

Are you sure you want to change the base?

Remove legacy app schema #6612

Uh oh!

Conversation

gonzaloriestra commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to test your changes?

Measuring impact

Checklist

Uh oh!

github-actions bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

gonzaloriestra commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gonzaloriestra commented Nov 12, 2025 •

edited

Loading

github-actions bot commented Nov 12, 2025 •

edited

Loading