Expose NodeContext#nesting_nodes attribute reader#3863
Open
janko wants to merge 7 commits intoShopify:mainfrom
Open
Expose NodeContext#nesting_nodes attribute reader#3863janko wants to merge 7 commits intoShopify:mainfrom
NodeContext#nesting_nodes attribute reader#3863janko wants to merge 7 commits intoShopify:mainfrom
Conversation
Contributor
|
I would also possibly benefit from this for this PR: Shopify/ruby-lsp-rails#671 |
rafaelfranca
approved these changes
Jan 19, 2026
Member
rafaelfranca
left a comment
rafaelfranca
left a comment
There was a problem hiding this comment.
This change makes sense to me
rafaelfranca
added
enhancement
Member
|
Let's please hold off merging this for now. We're about to start the work to integrate the new indexer into the LSP and there will be breaking API changes for add-ons. Exposing more APIs right now will likely just mean more breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this for implementing Shopify/ruby-lsp-rails#669, where I had to check whether a node is within an instance method of a subclass of
ActiveRecord::Migration[x.y](see relevant code).Since the latter isn't a direct class reference, I couldn't use the indexer to check the superclass of the migration class, as that was returning a fallback
::Object.