More refactoring to VersionManager#3918
Draft
rafaelfranca wants to merge 7 commits intorm-refactor-version-managerfrom
Draft
More refactoring to VersionManager#3918rafaelfranca wants to merge 7 commits intorm-refactor-version-managerfrom
VersionManager#3918rafaelfranca wants to merge 7 commits intorm-refactor-version-managerfrom
Conversation
rafaelfranca
changed the title
VersionManager
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafaelfranca
added
chore
Graphite App
graphite-app
bot
force-pushed
the
rm-refactor-version-manager
branch
2 times, most recently
from
e1bf26b to
4485199
Compare
…d use it across the codebase
Using unknown is safer than any because it forces you to narrow the type (like casting to Error) before accessing properties, preventing runtime errors.
Just make this implementation clearer by introducing intermediate variables.
graphite-app
bot
force-pushed
the
rm-refactor-2
branch
from
63cb2e6 to
b667162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract logic to check for Windows platform into a helper function and use it across the codebase.
Make sure all errors interface are the same for the ruby version managers.
Use
unknowninstead oferror.Using unknown is safer than any because it forces you to narrow the type
(like casting to Error) before accessing properties, preventing runtime
errors.
Extract helper to build the ruby executable uri
Extract method to check if a path exists in the filesystem
Improve sorting logic in Chruby version selection
Just make this implementation clearer by introducing intermediate
variables.
Improve documentation of Chruby and VersionManager