Skip to content

Conversation

@Pulik89
Copy link
Collaborator

@Pulik89 Pulik89 commented May 24, 2022

Заменил карусель и новости делового мира на новые

@Pulik89 Pulik89 requested a review from mdss-single May 24, 2022 06:21
@@ -136,7 +136,7 @@ strong {

&__title {
font-family: "Roboto", sans-serif;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удалить

font-size: 6rem;
font-size: 96px;
font-weight: 700;
color: #2c2c2c;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

переменная

@@ -163,7 +163,7 @@ strong {

&__subtitle {
font-family: "Roboto", sans-serif;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удалить

font-size: 4rem;
font-size: 64px;
font-weight: 700;
color: #2c2c2c;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

переменная

font-family: "Roboto", sans-serif;
font-size: 6rem;
font-size: 96px;
font-weight: 700;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

&__subtitle {
font-family: "Roboto", sans-serif;
font-size: 4rem;
font-size: 64px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -188,7 +188,7 @@ strong {

&__text {
font-family: "Roboto", sans-serif;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

&__text {
font-family: "Roboto", sans-serif;
font-size: 1.5rem;
font-size: 1.4rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

font-size: 1.5rem;
font-size: 1.4rem;
font-weight: 400;
color: #7a7a7a;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

@@ -215,15 +215,15 @@ strong {
justify-content: center;
align-items: center;
font-family: "Roboto", sans-serif;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

align-items: center;
font-family: "Roboto", sans-serif;
font-size: 1.5rem;
font-size: 1.4rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

font-size: 1.5rem;
font-size: 1.4rem;
font-weight: 500;
color: #ffffff;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

height: 76px;
// height: 76px;
border: none;
border-radius: 4px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

border: none;
border-radius: 4px;
padding: 24px 32px;
padding: 24px 10px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gridGap плюс откругление до кратного 8

padding: 24px 32px;
padding: 24px 10px;
margin: 0;
background-color: #1f75fe;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

@@ -342,7 +342,7 @@ strong {
justify-content: center;
align-items: center;
font-family: "Roboto", sans-serif;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

align-items: center;
font-family: "Roboto", sans-serif;
font-size: 6rem;
font-size: 4.8rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

font-size: 6rem;
font-size: 4.8rem;
font-weight: 700;
color: #2c2c2c;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

font-size: 4.8rem;
font-weight: 700;
color: #2c2c2c;
height: 113px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

что за магическое число? Что будет при переполнении?

align-items: center;
font-family: "Roboto", sans-serif;
font-size: 1.5rem;
font-family: "Roboto";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

font-family: "Roboto", sans-serif;
font-size: 1.5rem;
font-family: "Roboto";
font-size: 1rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

font-family: "Roboto";
font-size: 1rem;
font-weight: 400;
color: #7a7a7a;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

width: 67%;

@include md {
font-size: 1rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

font-size: 4rem;
font-size: 3rem;
font-weight: 700;
color: #ffffff;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

font-size: 3rem;
font-weight: 700;
color: #ffffff;
width: 864px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@@ -1335,10 +1331,10 @@ strong {
font-weight: 400;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -1335,10 +1331,10 @@ strong {
font-weight: 400;
color: #7a7a7a;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

height: 69px;
// height: 69px;
border: 1.5px solid #dadada;
border-radius: 8px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

width: 291px;
height: 69px;
// height: 69px;
border: 1.5px solid #dadada;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable for color

border: 1.5px solid #dadada;
border-radius: 8px;
padding: 24px 40px 24px 24px;
padding: 20px 9px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gridGap + round

@@ -1357,7 +1353,7 @@ strong {
line-height: 14px;
font-weight: 400;
color: #dadada;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

@@ -1357,7 +1353,7 @@ strong {
line-height: 14px;
font-weight: 400;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -1357,7 +1353,7 @@ strong {
line-height: 14px;
font-weight: 400;
color: #dadada;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

@@ -1378,7 +1374,8 @@ strong {
height: 69px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@@ -1378,7 +1374,8 @@ strong {
height: 69px;
border: 1.5px solid #dadada;
border-radius: 8px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

@@ -1378,7 +1374,8 @@ strong {
height: 69px;
border: 1.5px solid #dadada;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable for color

border: 1.5px solid #dadada;
border-radius: 8px;
padding: 24px 40px 24px 24px;
padding: 24px 10px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gridGap + round

@@ -1395,15 +1392,15 @@ strong {
justify-content: center;
align-items: center;
font-family: "Roboto", sans-serif;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

align-items: center;
font-family: "Roboto", sans-serif;
font-size: 1.5rem;
font-size: 1.3rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

font-size: 1.5rem;
font-size: 1.3rem;
font-weight: 500;
color: #1f75fe;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

height: 76px;
// height: 76px;
border: none;
border-radius: 4px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

border: none;
border-radius: 4px;
padding: 24px 29.5px;
padding: 24px 10px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gridGap + round

padding: 24px 29.5px;
padding: 24px 10px;
margin: 0;
background-color: #ffffff;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

@@ -1917,3 +1914,4 @@ strong {
font-weight: 400;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -1917,3 +1914,4 @@ strong {
font-weight: 400;
color: #2c2c2c;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

<div class="header-image">
<img
class="header-image__deck"
src="../../../../assets/images/franchise-landing/desk.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

путь можно указывать от корня /assets


<div class="header-image1">
<img
src="../../../../assets/images/franchise-landing/desk1.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

см выше про путь

mdss-single
mdss-single previously approved these changes Jun 15, 2022
@mdss-single mdss-single self-requested a review June 15, 2022 13:43
Copy link
Collaborator

@mdss-single mdss-single left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

см комментарии

@mdss-single mdss-single dismissed their stale review June 15, 2022 13:47

misslick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants