fix:🐛Reaction widget gets cutOff when it width is greater then messag…#124
Open
jaiminrana05 wants to merge 1 commit intomainfrom
Open
fix:🐛Reaction widget gets cutOff when it width is greater then messag…#124jaiminrana05 wants to merge 1 commit intomainfrom
jaiminrana05 wants to merge 1 commit intomainfrom
Conversation
jaiminrana05
force-pushed
the
fix/reaction_widget_issue_for_image
branch
from
5e37239 to
e83e1a9
Compare
vatsaltanna
reviewed
Sep 29, 2023
lib/src/widgets/reaction_widget.dart
Outdated
| fontSize: messageReactionConfig?.reactionSize ?? 13, | ||
| fontSize: isGroupChat | ||
| ? messageReactionConfig?.reactionSize ?? 13 | ||
| : 13, |
Collaborator
There was a problem hiding this comment.
should not be static for GroupChat
lib/src/widgets/reaction_widget.dart
Outdated
| Text( | ||
| reactionsSet.join(' '), | ||
| isGroupChat | ||
| ? reactionsSet.take(3).join(' ') |
Collaborator
There was a problem hiding this comment.
3 should not be static here, we can use 3 as default value but not static
jaiminrana05
force-pushed
the
fix/reaction_widget_issue_for_image
branch
5 times, most recently
from
0a61a38 to
605fb3d
Compare
…e width for the image message type.
apurva010
force-pushed
the
fix/reaction_widget_issue_for_image
branch
from
605fb3d to
9ad42b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… image message width.
Description
Before changes:
we can see that when the reaction widget width is greater than the image message width then it gets cut-off. And also for other messages, it overflows from the screen width.
Screen.Recording.2023-09-29.at.2.25.11.PM.mov
After changes:
Screen.Recording.2023-09-29.at.2.24.39.PM.mov
Note: The reaction widget background colour is change to red for getting a better understanding of this issue.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues