Open
Conversation
Contributor
stefannikolei
commented
Nov 14, 2025
stefannikolei
commented
- Used collection expressions were possible
- Added the used type were needed for clarification
- Disabled an Resharper rule With ImageSharp.sln.DotSettings --> It said that the Attribute ConstantExpected is not valid on floats
- Removed unused TestHelper
- Rewrote some tests to use utf8 string instead of raw byte array to make the test clearer
- Used collection expressions were possible - Added the used type were needed for clarification - Disabled an Resharper rule With ImageSharp.sln.DotSettings --> It said that the Attribute ConstantExpected is not valid on floats
stefannikolei
commented
Nov 14, 2025
| private static bool ShouldSkipBitmapTest => | ||
| !TestEnvironment.Is64BitProcess || (TestHelpers.ImageSharpBuiltAgainst != "netcoreapp3.1" && | ||
| TestHelpers.ImageSharpBuiltAgainst != "netcoreapp2.1"); | ||
| !TestEnvironment.Is64BitProcess; |
Contributor
Author
There was a problem hiding this comment.
This now gives a test error. It seems that those tests were now always skipped..
Member
There was a problem hiding this comment.
The Boolean result is not different here for 64bit builds
Contributor
Author
There was a problem hiding this comment.
it is different for 64bit builds. Having the second part, then it evaluates to true. Without the second part it evaluates to false
Member
There was a problem hiding this comment.
Ha! You’re right!
I wonder what’s wrong there then. Will investigate locally when I can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.