Introduce PHP5 compatible class constants#25
Open
fbrinker wants to merge 3 commits intoSkrol29:masterfrom
Open
Introduce PHP5 compatible class constants#25fbrinker wants to merge 3 commits intoSkrol29:masterfrom
fbrinker wants to merge 3 commits intoSkrol29:masterfrom
Conversation
|
👍 |
|
Hello @Skrol29, |
Owner
|
As mentioned in the documentation, the workaround to load the OpenTBS plugin using PHP auto-loading is simply : Does that solve the targeted problem ? |
Author
|
Okay I see. We could use the string variant, but why shouldn't we use the proper constant for the string And we would be able to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added class constants to resolve the problem that we have to use a class_exists before using the OPENTBS_PLUGIN constant. New / Additional usage:
clsOpenTBS::OPENTBS_PLUGIN. That will trigger the autoloading automatically.My goal was to keep a maximum of backwards compatibility, since I didn't find any minimum requirements. We could apply a change and use "public const" or even remove the define statements, but I guess that's not that important.