Error to user when back mod x is positive#1242
Open
spacey-sooty wants to merge 1 commit intoSleipnirGroup:mainfrom
Open
Error to user when back mod x is positive#1242spacey-sooty wants to merge 1 commit intoSleipnirGroup:mainfrom
spacey-sooty wants to merge 1 commit intoSleipnirGroup:mainfrom
Conversation
shueja
requested changes
Apr 24, 2025
Collaborator
shueja
left a comment
shueja
left a comment
There was a problem hiding this comment.
Implementation looks to be in the right direction.
This system should be used for all the must-be-positive config values like mass, MoI, etc.
Also this doesn't prevent a parseable but positive backModX from being submitted, does it? You would have to put the this.props.valid check in this.getValid() for that. At some point it makes more sense to have custom validity checks in the ExpressionStore itself, not the input element.
Resolves SleipnirGroup#1202 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
force-pushed
the
back-mod-x-positive
branch
from
13a3d02 to
0024718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1202
