Add OneID provider (Uzbekistan SSO)#1394
Open
aslnbxrz wants to merge 1 commit intoSocialiteProviders:masterfrom
Open
Add OneID provider (Uzbekistan SSO)#1394aslnbxrz wants to merge 1 commit intoSocialiteProviders:masterfrom
aslnbxrz wants to merge 1 commit intoSocialiteProviders:masterfrom
Conversation
Author
|
Why this pull request is not being accepted? Is anything wrong with it? |
atymic
reviewed
Feb 4, 2026
| ], | ||
| 'headers' => ['Accept' => 'application/json'], | ||
| ]); | ||
| Log::info('OneIDSocialiteLogout', [ |
atymic
requested changes
Feb 4, 2026
| 'accessTokenOrSessionId' => $accessTokenOrSessionId, | ||
| ]); | ||
| } catch (Throwable $e) { | ||
| Log::error('OneIDSocialiteThrow', [ |
Member
There was a problem hiding this comment.
same here, we cannot be catching excpetions like this
| */ | ||
| protected function getConfig(?string $key = null, mixed $default = null): mixed | ||
| { | ||
| $config = Config::get('services.oneid'); |
Member
There was a problem hiding this comment.
Is there a reason this can't be a function in the provider?
| // Odd => male, Even => female | ||
| return ((int)$pin[0]) % 2 ? 'male' : 'female'; | ||
| } | ||
| } No newline at end of file |
| 'access_token' => $token, | ||
| 'scope' => $this->getScope(), | ||
| ], | ||
| 'headers' => ['Accept' => 'application/json'], |
|
|
||
| protected function mapUserToObject(array $user): OneIDUser | ||
| { | ||
| // Build fallback name if full_name is missing |
Member
There was a problem hiding this comment.
Why is middle name after lastname? also remove the comments as they are not needed
Author
There was a problem hiding this comment.
Its typically like this in Uzbekistan fist_name + last_name + mid_name like "Bexruz Aslonov Botir o'g'li";
comments will be removed.
atymic
requested changes
Feb 7, 2026
Member
atymic
left a comment
atymic
left a comment
There was a problem hiding this comment.
Other issues still not resolved
| ], | ||
| 'headers' => ['Accept' => 'application/json'], | ||
| ]); | ||
| Log::info('OneIDSocialiteLogout', [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Uzbekistan’s OneID SSO provider. Endpoints: https://sso.egov.uz/sso/oauth/Authorization.do. Supports grant_type one_authorization_code and one_access_token_identify.