feat(DATAGO-121849): Document eval test instruction#954
Open
feat(DATAGO-121849): Document eval test instruction#954
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





What is the purpose of this change?
Running eval tests are confusing because there is no instruction or script for running eval tests.
How was this change implemented?
Added
evaluation/README.mdwith step-by-step instructions for running evaluation tests, environment variable requirements, and manual/automated setup options.Introduced new Makefile targets for evaluation tests (
test-eval,test-eval-local,test-eval-workflow,test-eval-remote) and updated help text to document these options.Improved configuration setup in
evaluation/run.pyby ensuring the configs directory exists and automatically copyingshared_config.yamlfrom examples if missing.Key Design Decisions
How was this change tested?
make test-evaland verified that the virtual environment is created and eval tests are executed.Is there anything the reviewers should focus on/be aware of?
uvpackage manager in the Make file. Therefore, we had to directly activate virtual environments viasourcecommand and run the sam application.