On-chain verification + configurability of verification features#253
Open
gertjandemulder wants to merge 22 commits intoSolidLabResearch:developmentfrom
Open
On-chain verification + configurability of verification features#253gertjandemulder wants to merge 22 commits intoSolidLabResearch:developmentfrom
gertjandemulder wants to merge 22 commits intoSolidLabResearch:developmentfrom
Conversation
…ment Merging for v2.1.1
…ment Merge for v2.2.0
…ment Merge for release v2.2.1
…ment Merge for Release v2.2.1
…ment Merge for Release v2.2.1 (the sequal...)
gertjandemulder
changed the title
bjdmeest
reviewed
Dec 12, 2025
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Outdated
Show resolved
Hide resolved
bjdmeest
reviewed
Dec 12, 2025
bjdmeest
reviewed
Dec 15, 2025
main/src/components/ActionBar/ChainVerificationIcon/ChainVerificationIcon.jsx
Show resolved
Hide resolved
bjdmeest
reviewed
Dec 15, 2025
| <SourceVerificationIcon httpProxies={query.httpProxies} source={source} /> | ||
| </TableCell> | ||
| { !!vc.enabled && <TableCell> <SourceVerificationIcon httpProxies={query.httpProxies} source={source} /> </TableCell> } | ||
| { !!onchain.enabled &&<TableCell> <ChainVerificationIcon endpoint={onchain.endpoint} source={source} /> </TableCell> } |
Collaborator
There was a problem hiding this comment.
I think this won't work if onchain.enabled = true and onchain.endpoint is not filled in
Collaborator
|
Yeah so... This needs tests. Without the API setup, i.e., mocking the anchoring/... server similar to https://github.com/SolidLabResearch/miravi-a-linked-data-viewer/blob/main/test/scripts/start-bad-cors-server.mjs , but adding the cypress tests such as https://github.com/SolidLabResearch/miravi-a-linked-data-viewer/blob/main/test/cypress/e2e/verify-source.cy.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables i) on-chain verification of the data sources; ii) configuration of verification features (i.e., source verification & on-chain verification).
On-chain verification
On-chain verification refers to verifying whether the anchored data source has not been tampered with since the time of it was published.
Configuration of verification features
Miravi can now be configured to enable/disable source verification and on-chain verification.