[Feature] Add $properties Iceberg Metadata Table#68504
[Feature] Add $properties Iceberg Metadata Table#68504mixermt wants to merge 5 commits intoStarRocks:mainfrom
Conversation
|
@cursor review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a89c05cbd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...data-reader/src/main/java/com/starrocks/connector/iceberg/IcebergPropertiesTableScanner.java
Outdated
Show resolved
Hide resolved
|
I'm curious why you don't directly use |
...data-reader/src/main/java/com/starrocks/connector/iceberg/IcebergPropertiesTableScanner.java
Show resolved
Hide resolved
...data-reader/src/main/java/com/starrocks/connector/iceberg/IcebergPropertiesTableScanner.java
Show resolved
Hide resolved
@Youngwb SHOW CREATE TABLE output is not queryable data, you need to make huge parsing effort to get simple table properties. |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
1df50d9 to
589f0ab
Compare
|
@alvin-celerdata , @stephen-shelby |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 589f0ab5bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...data-reader/src/main/java/com/starrocks/connector/iceberg/IcebergPropertiesTableScanner.java
Outdated
Show resolved
Hide resolved
[Java-Extensions Incremental Coverage Report]❌ fail : 0 / 2 (00.00%) file detail
|
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@alvin-celerdata what are the next steps? First SR contribution. |
Signed-off-by: Michael Taranov <michael.taranov@taboola.com>
Signed-off-by: Michael Taranov <michael.taranov@taboola.com>
…test Signed-off-by: Michael Taranov <michael.taranov@taboola.com>
Signed-off-by: Michael Taranov <michael.taranov@taboola.com>
Signed-off-by: Michael Taranov <michael.taranov@taboola.com>
b9ce6d4 to
812446a
Compare
🌎 Translation Required?✅ All translation files are up to date.
|
Why I'm doing:
Currently, StarRocks exposes various Iceberg metadata through metadata tables (
table$snapshots,table$history,table$partitions, etc.), but table-level properties are not accessible via SQL. Users need to use external tools or access the Iceberg catalog directly to view configuration properties likelocation,write.format.default, or compression settings.This feature adds a
table$propertiesmetadata table to expose Iceberg table properties, similar to Trino's implementation, providing a consistent and queryable interface for table configuration.What I'm doing:
Add support for querying Iceberg table properties via
table$propertiesmetadata table syntax:Returns table properties as key-value pairs:
Implementation includes:
PROPERTIEStoMetadataTableTypeenumIcebergPropertiesTableclass withkey/valueschemaIcebergPropertiesTableScannerto read fromtable.properties()APIICEBERG_PROPERTIES_TABLEto thriftTTableTypeenumFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: