Fixed incorrect error propagation in rebin_data #953
Merged
+32
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by Lightcurve.rebin(). Changed docstring to use non-trivial example (where error != 1). Added test and changelog file.
Updated test_binning_works_correctly to include biny, binyerr, and nsamples. Removed redundant tests for bin edges, bin values, and nsamples.
Updated y_err to have a value of 2 for testing purposes.
matteobachetti
approved these changes
Feb 11, 2026
Member
|
Thanks @ericymiao ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue(s)/PR(s)
Fixes a bug in rebin_data where input standard errors are combined linearly and square-rooted, treating them like variances rather than standard errors. Rebinned errors were affected by a factor of$1/\sqrt(\sigma)$
Provide an overview of the implemented solution or the fix and elaborate on the modifications.
Squared input standard errors before summing and propagating.$\sigma \neq 1$ ). With the trivial example, the error cannot be detected as $\sigma = \sigma^{2} = 1$
Added new test in
test_utils.pyChanged docstring example to nontrivial example (where