Composite Refactoring with Strategies

[beshur]

No description provided.

[endway]

We can make it a factory method and get rid off statusArgs.
StatusStrategies.getCheckSelector(".jouele-status-playing .jouele-info-control-button-icon_pause")

[beshur]

I would keep things generic for all the strategies, i.e. passing the args as a property on the options object, as I see there will be other strategies with a different params count etc.

[endway]

wow, looks like a magic :)
maybe simple declarative way, like radiolist.com.ua below?

[endway]

I mean, in this case you should always remember what's 2, 3, 4 arguments for.

[beshur]

It's true, but it will be very redundant with the amount of services that we have

[endway]

According to some clean code guides, it's better to leave exclusions in the beginning and do stuff after.

static getStatus() {
  let status = Status.PAUSED;
  const videos = document.getElementsByTagName("video");
  if (videos.length > 0) {
    const hasPlayingVideo = Array.from(videos).some((player) => !player.paused);
    status = hasPlayingVideo ? Status.PLAYING : Status.PAUSED;
  }
  return status;
}

becomes

static getStatus() {
    const videos = document.getElementsByTagName("video");

    if (!videos.length) {
        return Status.PAUSED;
    }

    const hasPlayingVideo = Array.from(videos).some((player) => !player.paused);

    return hasPlayingVideo
      ? Status.PLAYING
      : Status.PAUSED;
}

[beshur]

Here I don't have an exclusion - it's the actual condition of continuation.

Also it's always good to have one return.

I would keep it like this.

[endway]

looks funny :))))
play() => pause()

[beshur]

The method is static, so it won't work.

Oh, actually, I added separate args here, I'll update.