Enabling population of individual namelist parameters#1355
Enabling population of individual namelist parameters#1355jasonfleming wants to merge 30 commits intomasterfrom
Conversation
|
|
|
Ok I think this is working except for defining the ADCIRC version support for various features. Let's discuss next time we meet. |
jasonfleming
force-pushed
the
issue-1354
branch
from
87ed29e to
ce51d57
Compare
@jasonfleming remind me, was there anything actionable for me on this other than a review when you marked it ready? |
|
Hey @wwlwpd I am adding/consolidating/refactoring some of this as well as adding tests. Nothing for you to do until this is ready. Hope to finish implementation and testing by Monday. |
wwlwpd
left a comment
wwlwpd
left a comment
There was a problem hiding this comment.
Lots of good looking work, looks fine to me!
|
After this I should jump on |
jasonfleming
force-pushed
the
issue-1354
branch
from
53fe533 to
71cae90
Compare
|
Rebased to latest master branch; testing will resume. Not sure whether any further development will be required. |
…any tests, and uses code from ASGS for fidelity to Operations
…; consolidated repeated code for finishing tests
jasonfleming
force-pushed
the
issue-1354
branch
from
71cae90 to
e592aa9
Compare
…ers; adding support for nws08Control namelist relevant to #1606 ; added test cases for symmetric vortex and configured namelist parameter writing
…for namelist parameter write specifications; added listing of failed tests to unit testing for generateDynamicInput.sh
…cii output although it is not checked
…elist parameter values with default values according to data type; fixed quoting of write specifiers for namelist values in control yaml; started adding support to control writing of entire namelists
…tart files; fixed comment line for nodal attributes in wind10m fort.15
2 participants
resolves #1354 ... testing this now