Skip to content

Internal: Fix wrong input type being used in our github server workflow file #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
plocket wants to merge 4 commits into
base: v5
Choose a base branch
from
Draft

Internal: Fix wrong input type being used in our github server workflow file #829

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a8da6a
Troubleshoot workflow input `enable_tmate`
plocket Dec 4, 2023
dc93d98
Use inputs.var as opposed to github.event.input.var
plocket Dec 4, 2023
f783099
Use toJson() instead of fromJson()
plocket Dec 4, 2023
4756c32
Compare to 'true', I suppose, since boolean didn't work before
plocket Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/github_server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
# relative paths to action files
- uses: actions/checkout@v3

- run: echo ${{ toJSON(inputs.enable_tmate) }}
shell: bash

- name: ALKiln - Start the isolated temporary docassemble server on GitHub
id: github_server
#### Developer note: you'll need to replace `.` with the path to
Expand All @@ -57,7 +60,7 @@ jobs:
#### Developer note: You probably don't need this
# Optional debugging to explore things like config issues
- name: Docker debug tmate session
if: ${{ github.event.inputs.enable_tmate }}
if: ${{ toJSON(inputs.enable_tmate) == 'true' }}
uses: mxschmitt/action-tmate@v3

#### Developer note: You probably don't need this
Expand Down