[IMPROVEMENT] added Musixmatch lyrics source#2683
Open
martinmake wants to merge 3 commits intoSwagLyrics:masterfrom
Open
[IMPROVEMENT] added Musixmatch lyrics source#2683martinmake wants to merge 3 commits intoSwagLyrics:masterfrom
martinmake wants to merge 3 commits intoSwagLyrics:masterfrom
Conversation
|
Hello @martinmake! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-20 15:59:01 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2683 +/- ##
==========================================
- Coverage 96.90% 90.86% -6.04%
==========================================
Files 3 3
Lines 194 219 +25
Branches 21 24 +3
==========================================
+ Hits 188 199 +11
- Misses 5 17 +12
- Partials 1 3 +2
Continue to review full report at Codecov.
|
Mondonno
approved these changes
Jan 12, 2021
Mondonno
left a comment
There was a problem hiding this comment.
I think this is good optimalization :) Maybe i change this soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Implements #2682