Draft
Conversation
…or on local machine
fanlai0990
reviewed
Aug 26, 2022
docker/driver.py
Outdated
| print_help: bool = False | ||
| if len(sys.argv) > 1: | ||
| if sys.argv[1] == 'submit' or sys.argv[1] == 'start': | ||
| redis_exec = '/usr/bin/redis-server' |
Collaborator
There was a problem hiding this comment.
Can we remove the hardcoded path? Instead, use some like os.environ["REDIS_PATH"]
| @@ -6,6 +6,7 @@ dependencies: | |||
| - tensorboard | |||
Collaborator
There was a problem hiding this comment.
I remember you mentioned that some tf version is not compatible. Can you please update tf version here too?
|
|
||
| # ======== redis client ======== | ||
| # <host, port, ...> should be specified in args | ||
| host = "127.0.0.1" |
Collaborator
There was a problem hiding this comment.
Please remove any hard code in the future, using args.xxx instead.
Collaborator
|
Thanks a lot for your contribution! Let's try to run an e2e evaluation to validate the learning curve and Redis overhead first. |
added 3 commits
October 2, 2022 23:06
… start and client init logic
Collaborator
|
Thanks for your contribution. Can you please
We really appreciate your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To integrate Redis into aggregator for saving aggregation data.
Related issue number
N/A
Checks
Note: