Fix broken install: Lower rapidjsonr dependency to 1.2.0 (latest available on CRAN).#82
Open
RileyLeff wants to merge 1 commit intoSymbolixAU:masterfrom
Open
Fix broken install: Lower rapidjsonr dependency to 1.2.0 (latest available on CRAN).#82RileyLeff wants to merge 1 commit intoSymbolixAU:masterfrom
RileyLeff wants to merge 1 commit intoSymbolixAU:masterfrom
Conversation
Collaborator
|
I'm not sure I see the need to downgrade the linked version. The description specifies the 'remotes' for The CRAN version links to 1.2.0 The tests work fine for me |
Author
|
Reading this back, I probably should've provided some more context in my first message. My initial problem was that I couldn't get CRAN jsonify to install from source after upgrading to MacOS Tahoe on M1. Source install on ubuntu x86 seems to work fine. The error message is pasted at the end of this comment because it's very long. CRAN has jsonify 1.2.2 as the most recent version. For some reason the binary install from CRAN wasn't working for me yesterday, but seems to be working ok now, maybe an environment problem on my end. Source install from CRAN still gives me the same error today. I forked this repo with the intention of fixing the compilation bug, but found that someone else had already edited file of interest, commenting that it was an update for jsonify version 1.2.3. So naturally I tried installing jsonify directly from this repo, but got this error:
So while my first thought was to just bump down the dependency to the latest CRAN version, seems like the problem is that pak is not detecting the remote correctly. Interestingly this seems to work fine if I install with devtools or remotes. My understanding is that the remotes section of the description should be formatted like Thanks for quick response! Long compilation error message below (which I believe is fixed as of 1.2.3)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, looks like jsonify depends on a version of rapidjsonr that isn't available on CRAN. The DESCRIPTION asks for 1.2.1 but the latest available is 1.2.0 and the CRAN page doesn't seem to link to a github repo. This was breaking package installs for me. Installs fine with 1.2.0.
If you're also currently stuck on a jsonify install and this PR hasn't been merged yet, try this:
I tried running the tests and found that the tests don't work, but they fail in the exact same way if I revert to the previous commit, so I think it's fine: