Skip to content

fixing the linkage for no pregnancy event#76

Merged
MJC598 merged 4 commits intomainfrom
detect-linking-hotfix
Mar 11, 2025
Merged

fixing the linkage for no pregnancy event#76
MJC598 merged 4 commits intomainfrom
detect-linking-hotfix

Conversation

@MJC598
Copy link
Contributor

@MJC598 MJC598 commented Mar 10, 2025

It was just a dumb thing on the query requiring a pregnancy column. Basically made the SQL query conditional on if the pregnancy event exists.

@MJC598 MJC598 requested a review from ddbaptiste March 10, 2025 20:07
@MJC598 MJC598 self-assigned this Mar 10, 2025
Copy link
Member

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting one change, for which I've added a suggestion. Additionally, I'm hoping that this PR can be merged after #77, which I just submitted, which should hopefully clean up what's going on with the headers currently.

@MJC598 MJC598 requested a review from ddbaptiste March 10, 2025 20:34
MJC598 and others added 2 commits March 10, 2025 17:00
Co-authored-by: Dimitri Baptiste <55843498+ddbaptiste@users.noreply.github.com>
Copy link
Member

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, approved!

@MJC598 MJC598 force-pushed the detect-linking-hotfix branch from ab5921f to 22062e8 Compare March 10, 2025 21:19
Copy link
Member

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting the headers get fixed such that Project is the Git root folder rather than the folder containing the file.

@MJC598 MJC598 requested a review from ddbaptiste March 11, 2025 13:15
Copy link
Member

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@MJC598 MJC598 merged commit 0b12e4b into main Mar 11, 2025
1 check passed
@MJC598 MJC598 deleted the detect-linking-hotfix branch March 11, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants