Open
Conversation
…ult (user can use it if they need it). - Rename of original reports as they often conflict with other libraries.
Author
|
@T-vK do you think it would be possible to merge this PR? 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I hit several times collision with other libraries in 2 aspects:
To fix it, I moved KeyCodes into separate file as they are not needed in main file and use can control what they want to use this way. And for KeyReport I renamed it (gave it prefix).
This allows to use library with other USB HID libraries. I can make adjustments to my changes if you have better idea how to approach it :)