add test for #2838 (or, more precisely, for #2839, the fix for #2838)#2867
Merged
martindholmes merged 2 commits intodevfrom Feb 11, 2026
Merged
add test for #2838 (or, more precisely, for #2839, the fix for #2838)#2867martindholmes merged 2 commits intodevfrom
martindholmes merged 2 commits intodevfrom
Conversation
with NO attributes, or any TWO of key=, name=, & ref= is flagged as an error.
Member
Author
|
Well that’s an interesting test failure. Not sure what to do about it off the top of my head. Have to go offline to walk dogs, hope to look in ~1 hr. |
jing reporting error at different columns on my system vs gitHub or docker?)
Contributor
martindholmes
left a comment
martindholmes
left a comment
There was a problem hiding this comment.
Tested, and reviewed. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check to detest.xml¹ that a
<dataRef>element with no attributes, or any two of@key,@name, &@refis flagged as an error.Note
¹ Because adding it to detest.odd would break the build, as these errors are caught be RELAX NG, not by Schematron.