Fix unreachable reinterpret instruction execution#334
Open
abelstuker wants to merge 5 commits intomainfrom
Open
Fix unreachable reinterpret instruction execution#334abelstuker wants to merge 5 commits intomainfrom
abelstuker wants to merge 5 commits intomainfrom
Conversation
abelstuker
force-pushed
the
fix/unreachable-reinterpret-instr
branch
from
b76a6f8 to
b1b6790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #332.
The reinterpret instructions are covered by the
i_instr_conversionfunction ininstructions.cpp.However, this function was never called by the interpreter for reinterpret instructions since its opcodes (
0xbc ... 0xbf) were not included in the switch case range for the conversion instructions.Therefore, the switch case range was extended to include the reinterpret instruction opcodes.