Skip to content

[BUGFIX] Allow null value as input for f:replace (#1282) #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s2b merged 1 commit into from
Feb 2, 2026
Merged

[BUGFIX] Allow null value as input for f:replace (#1282) #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ViewHelpers/ReplaceViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function render(): string
$value = $this->arguments['value'] ?? $this->renderChildren();
$search = $this->arguments['search'];
$replace = $this->arguments['replace'];
if ($value === null || (!is_scalar($value) && !$value instanceof \Stringable)) {
if ($value !== null && !is_scalar($value) && !$value instanceof \Stringable) {
throw new \InvalidArgumentException('A stringable value must be provided.', 1710441987);
}
if ($search === null) {
Expand Down
11 changes: 5 additions & 6 deletions tests/Functional/ViewHelpers/ReplaceViewHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,6 @@ final class ReplaceViewHelperTest extends AbstractFunctionalTestCase
{
public static function throwsExceptionForInvalidArgumentDataProvider(): iterable
{
yield 'without value' => [
'<f:replace search="foo" replace="bar" />',
[],
1710441987,
'A stringable value must be provided.',
];
yield 'array as value' => [
'{value -> f:replace(search: \'foo\', replace: \'bar\')}',
['value' => [1, 2, 3]],
Expand Down Expand Up @@ -132,6 +126,11 @@ public static function renderDataProvider(): iterable
['value' => ''],
'',
];
yield 'with null as value' => [
'<f:replace search="foo" replace="bar" value="{null}" />',
[],
'',
];
}

#[DataProvider('renderDataProvider')]
Expand Down