Skip to content

Conversation

@zhanba
Copy link
Member

@zhanba zhanba commented Feb 6, 2026

Screen record

https://jam.dev/c/d13db240-0509-44b3-b547-faadbdcd4717

Summary

  • Allow the planner agent to ask clarification questions via askFollowupQuestion tool before generating implementation plans
  • Update planner workflow with clarification phase and ambiguity gate to ensure high-quality, decision-complete plans
  • Ensure planner agent always runs in manual mode for user interaction
  • Fix typo: askFollowupQuestionsaskFollowupQuestion in prompts
  • Auto navigate the planner agent into detail page;Filter askFollowupQuestion part in inline subtask display mode
  • disable askFollowupQuestion options if this toolcall is not last part

Test plan

  • Verify planner agent can ask clarification questions when requirements are ambiguous
  • Verify planner agent runs in manual mode (not offhand)
  • Verify existing agent behavior is unchanged

🤖 Generated with Pochi | Task

…tion

Allow the planner agent to ask clarification questions before generating
implementation plans. This improves plan quality by ensuring ambiguities
are resolved with user input rather than assumptions.

Changes:
- Add askFollowupQuestion to planner's available tools
- Update planner workflow with clarification phase and ambiguity gate
- Ensure planner agent always runs in manual mode for user interaction
- Fix typo: askFollowupQuestions → askFollowupQuestion in prompts

🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-5029f743fae34ddab41d50fedc543a10)

Co-Authored-By: Pochi <noreply@getpochi.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.65%. Comparing base (9dc3f95) to head (63008e6).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/vscode-webui/src/components/task-thread.tsx 0.00% 19 Missing ⚠️
packages/tools/src/new-task.ts 0.00% 6 Missing ⚠️
...eatures/tools/components/ask-followup-question.tsx 0.00% 6 Missing ⚠️
.../approval/components/tool-call-approval-button.tsx 0.00% 3 Missing ⚠️
...code-webui/src/features/tools/components/index.tsx 0.00% 2 Missing ⚠️
packages/cli/src/task-runner.ts 0.00% 1 Missing ⚠️
...code-webui/src/components/message/message-list.tsx 0.00% 1 Missing ⚠️
...vscode-webui/src/features/retry/hooks/use-retry.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (62.50%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   13.61%   13.65%   +0.04%     
==========================================
  Files         671      673       +2     
  Lines       59721    59958     +237     
  Branches     1749     1761      +12     
==========================================
+ Hits         8130     8189      +59     
- Misses      51320    51497     +177     
- Partials      271      272       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhanba zhanba marked this pull request as draft February 6, 2026 13:47
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LG

@wsxiaoys
Copy link
Member

wsxiaoys commented Feb 9, 2026

Please share a few sessions / screenshots to show a few examples?

@zhanba zhanba marked this pull request as ready for review February 9, 2026 06:34
@zhanba zhanba changed the title feat(planner): enable askFollowupQuestion for planner agent fix(planner): optimize planner agent to better ask user question Feb 9, 2026
@zhanba zhanba changed the title fix(planner): optimize planner agent to better ask user question feat(planner): add clarification questions before plan generation Feb 9, 2026
@zhanba zhanba changed the title feat(planner): add clarification questions before plan generation fix(planner): add clarification questions before plan generation Feb 9, 2026
@zhanba zhanba added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit 9b86cbc Feb 9, 2026
3 checks passed
@zhanba zhanba deleted the planner-question branch February 9, 2026 08:06
liangfung pushed a commit that referenced this pull request Feb 9, 2026
* feat(planner): enable askFollowupQuestion for planner agent clarification

Allow the planner agent to ask clarification questions before generating
implementation plans. This improves plan quality by ensuring ambiguities
are resolved with user input rather than assumptions.

Changes:
- Add askFollowupQuestion to planner's available tools
- Update planner workflow with clarification phase and ambiguity gate
- Ensure planner agent always runs in manual mode for user interaction
- Fix typo: askFollowupQuestions → askFollowupQuestion in prompts

🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-5029f743fae34ddab41d50fedc543a10)

Co-Authored-By: Pochi <noreply@getpochi.com>

* fix(vscode-webui): implement filterTrailingAskFollowupQuestion to prevent UI display in subtasks

* fix(tools): add isLastPart prop to ToolProps and related components for improved state handling

* fix(task-thread): simplify filterTrailingAskFollowupQuestion logic to directly check last part type

---------

Co-authored-by: Pochi <noreply@getpochi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants