Fix image extension filtering to support case-insensitive matches#28
Open
shreyasi12345 wants to merge 3 commits intoTaeyoung96:masterfrom
Open
Fix image extension filtering to support case-insensitive matches#28shreyasi12345 wants to merge 3 commits intoTaeyoung96:masterfrom
shreyasi12345 wants to merge 3 commits intoTaeyoung96:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the image file loading logic to ensure files with extensions like
.JPG,.Png, etc., are correctly included. Previously, only lowercase extensions were supported.Changes
rglob()calls with a unified search and filter using.suffix.lower().Motivation
This makes the code more reliable across different systems and file sources where file extensions may not be consistently lowercase.