Fix Feed page for search predicates with overlay array predicates#676
Open
Julienng wants to merge 2 commits intoTanStack:mainfrom
Open
Fix Feed page for search predicates with overlay array predicates#676Julienng wants to merge 2 commits intoTanStack:mainfrom
Julienng wants to merge 2 commits intoTanStack:mainfrom
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
89fff6b to
24ca308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
When using the page https://tanstack.com/feed?page=1&pageSize=50&viewMode=table&libraries=%5B%22router%22%5D
The query in Drizzle is failing because of an incorrect query generation:
By looking and searching at the Drizzle doc, I've found
arrayOverlaps(posts.tags, ['Typescript', 'ORM'])(https://orm.drizzle.team/docs/operators#arrayoverlaps)When looking at the generated query, it looks like this:
So the query's initial behavior is maintained but without an SQL error.
PR Status:
--no-verifyto get to the PR. need a check if everything is goodARRAY[${sql.joinpatterns, but two of them needed a cast for the enum values:filters.useCasesanddata.capabilityFilter