Skip to content

chore: improve insert transaction response#3026

Open
mfrankovi wants to merge 1 commit intodevelopfrom
insert_trx_resp
Open

chore: improve insert transaction response#3026
mfrankovi wants to merge 1 commit intodevelopfrom
insert_trx_resp

Conversation

@mfrankovi
Copy link
Contributor

Add additional info in insert transaction response

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the insert transaction response to include additional status messages by changing the return type from TransactionStatus to a pair containing TransactionStatus and a string message.

  • Updated tests to check the first element of the returned pair.
  • Refactored transaction_queue and transaction_manager implementations and their header declarations to provide detailed error messages.
  • Adjusted network packet handler logic to use the new response format.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/full_node_test.cpp Updated test comparison to use the first element of the returned pair.
libraries/core_libs/network/src/tarcap/packets_handlers/latest/transaction_packet_handler.cpp Refactored status checks for the new response pair format.
libraries/core_libs/consensus/src/transaction/transaction_queue.cpp Changed insert() return type to include a message and updated error responses.
libraries/core_libs/consensus/src/transaction/transaction_manager.cpp Adjusted insertValidatedTransaction() to return status-message pair and updated condition handling accordingly.
libraries/core_libs/consensus/include/transaction/transaction_queue.hpp Updated function signature to reflect the new return type.
libraries/core_libs/consensus/include/transaction/transaction_manager.hpp Updated function signature to reflect the new return type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants