fix: sanitize name before insert and have more defensive checks/lookups before inserting combat events#415
Open
exkungen wants to merge 1 commit intoTeam-Silver-Sphere:masterfrom
Conversation
exkungen
changed the title
exkungen
changed the title
exkungen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where combat events fail to log when players use non-ASCII symbols or names with leading spaces. I implemented a global
sanitizeNamemethod to strip non-ASCII characters and trim whitespaces. The event handlers now include a manual lookup viathis.server.getPlayerByNameto resolve player objects when the initial log parser fails. I also updated the ID resolution to fall back toeosIDif asteamIDis unavailable to ensure records are always linked to a unique identifier.