Add scikit-learn-contrib/stability-selection and improve randomized_l1 transformers#308
Open
teabolt wants to merge 7 commits intoTeamHG-Memex:masterfrom
Open
Add scikit-learn-contrib/stability-selection and improve randomized_l1 transformers#308teabolt wants to merge 7 commits intoTeamHG-Memex:masterfrom
teabolt wants to merge 7 commits intoTeamHG-Memex:masterfrom
Conversation
…mer (if scikit-learn-contrib/stability-selection available)
…earn) and stability_selection (scikit-learn-contrib)
… sklearn/transform.py
…andomizedLasso of scikit-learn < 0.19 (fix failed CI build)
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 97.09% 97.07% -0.03%
==========================================
Files 44 44
Lines 2856 2868 +12
Branches 542 543 +1
==========================================
+ Hits 2773 2784 +11
- Misses 45 46 +1
Partials 38 38
|
Contributor
Author
|
Re: two test parametrizations for RandomizedLasso, one for scikit-learn < 0.19 and another for scikit-learn >= 0.19. It might be possible to reduce these to just one test by passing certain parameters to the RandomizedLasso so that the same features are selected in both scikit-learn versions. See also history of randomized_l1 https://github.com/scikit-learn/scikit-learn/commits/0.20.X/sklearn/linear_model/randomized_l1.py for what might be causing the difference in selected features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305.
stability_selection.StabilitySelection(https://github.com/scikit-learn-contrib/stability-selection) as an argument totransform_feature_names.Coverage should increase once scikit-learn 0.21 and scikit-learn-contrib/stability-selection are tested against (could modify the tox config for this?).
If more use cases come up for functions like
register_notnoneandinstantiate_notnone, they could be moved tobase_utils.pyor similar.