add assertions after memory alloc to make sure the alloc is successful.#2313
Open
ken4647 wants to merge 1 commit intoTencent:masterfrom
Open
add assertions after memory alloc to make sure the alloc is successful.#2313ken4647 wants to merge 1 commit intoTencent:masterfrom
ken4647 wants to merge 1 commit intoTencent:masterfrom
Conversation
…etArrayRaw` and `DoCopyMembers` in document.h.
Member
|
|
tmorrisman
approved these changes
Jun 18, 2025
|
Thank you!! Adding this helped to track down a problem that was otherwise a silent failure. Without this, the parse call showed no error but contained no DOM objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add assertions after memory alloc for
SetStringRaw,SetObjectRaw,SetArrayRawandDoCopyMembersin document.h.