Skip to content

CMakeLists: increase compatibility.#2334

Open
heitbaum wants to merge 1 commit intoTencent:masterfrom
heitbaum:patch-1
Open

CMakeLists: increase compatibility.#2334
heitbaum wants to merge 1 commit intoTencent:masterfrom
heitbaum:patch-1

Conversation

@heitbaum
Copy link

Fixes the following warning issued by cmake-4.0.0:

CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

Fixes #2333

Fixes the following warning issued by cmake-4.0.0:

CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.
@tencent-adm
Copy link
Member

tencent-adm commented Mar 28, 2025

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@heitbaum
Copy link
Author

@miloyip - if this PR is ok, could it be merged?

@LecrisUT
Copy link

Could we deprecate this in favor of #2340. Generally it is preferred to make the higher bound as high as possible, heck even 5.0 would be a good option if the CI is setup properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With cmake-4.0.0 now released can this be updated

3 participants