CMakeLists: fix add_custom_command warning#2337
Open
heitbaum wants to merge 1 commit intoTencent:masterfrom
Open
CMakeLists: fix add_custom_command warning#2337heitbaum wants to merge 1 commit intoTencent:masterfrom
heitbaum wants to merge 1 commit intoTencent:masterfrom
Conversation
Fixes:
CMake Warning (dev) at CMakeLists.txt:104 (add_custom_command):
Exactly one of PRE_BUILD, PRE_LINK, or POST_BUILD must be given. Assuming
POST_BUILD to preserve backward compatibility.
Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
Run "cmake --help-policy CMP0175" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
This warning is for project developers. Use -Wno-dev to suppress it.
Ref: https://cmake.org/cmake/help/v3.0/command/add_custom_command.html
Author
|
@miloyip - if this PR is ok, could it be merged? |
LecrisUT
suggested changes
May 23, 2025
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
LGTM, but I suggest a more modern design.
Note that this is an error in later CMake versions, so indeed, please merge.
It would also be preferred if that would be moved inside the RAPIDJSON_BUILD_DOC check.
Comment on lines
164
to
166
| add_custom_target(travis_doc) | ||
| add_custom_command(TARGET travis_doc | ||
| add_custom_command(TARGET travis_doc POST_BUILD | ||
| COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/travis-doxygen.sh) |
There was a problem hiding this comment.
Use the following instead
add_custom_target(travis_doc
COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/travis-doxygen.sh
)
Author
|
@miloyip hopong you could review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Ref: https://cmake.org/cmake/help/v3.0/command/add_custom_command.html