Correct the behaviors of WriteBuffer#2346
Open
EstherWx wants to merge 1 commit intoTencent:masterfrom
Open
Conversation
Member
|
|
admorgan
reviewed
Jun 27, 2025
admorgan
left a comment
admorgan
left a comment
There was a problem hiding this comment.
The second commit fixes a bug introduced in the first. It would be better to combine them into one commit.
WriteBuffer attempt to dereference a pointer without any check. Adds a safeguard to prevent dereferencing a null pointer to fix it and nullPointer warning detected by cppcheck. Besides, WriteBuffer always does hashing and returns true. According to the reference of FNV-1a for Hash algorithm, the original code uses a while loop to iterate over the buffer, checking that the current position is less than the end. WriteBuffer should not do hashing when the length is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteBuffer attempt to dereference a pointer without any check. Adds a safeguard to prevent dereferencing a null pointer to fix it and nullPointer warning detected by cppcheck.
Besides, WriteBuffer always does hashing and returns true. According to the reference of FNV-1a for Hash algorithm, the original code uses a while loop to iterate over the buffer, checking that the current position is less than the end. WriteBuffer should not do hashing when the length is 0.