Skip to content

Don't use windows legacy terminal support when ctypes is not available#3911

Open
youknowone wants to merge 1 commit intoTextualize:masterfrom
youknowone:no-ctypes
Open

Don't use windows legacy terminal support when ctypes is not available#3911
youknowone wants to merge 1 commit intoTextualize:masterfrom
youknowone:no-ctypes

Conversation

@youknowone
Copy link

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

AI?

  • AI was used to generate this PR

AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Hello, I am a developer of RustPython project. RustPython currently doesn't have ctypes, but trying to support pip.
rich is currently bundled in pip. When pip is trying to use rich on legacy windows terminal, it requires ctypes and raising error.
This patch changes rich not to turn on legacy windows terminal supports when ctypes is not available.

Could you check if this is an acceptable approach for rich? Then I will add a test to prevent regressions.

@willmcgugan
Copy link
Member

It does mean that it won't work on legacy windows. If RustPython only works on more modern Windows, then that might be an acceptable solution.

Although I think I would prefer a more explicit check. i.e. Check for RustPython rather than the absence of ctypes. Is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants