Don't use windows legacy terminal support when ctypes is not available#3911
Open
youknowone wants to merge 1 commit intoTextualize:masterfrom
Open
Don't use windows legacy terminal support when ctypes is not available#3911youknowone wants to merge 1 commit intoTextualize:masterfrom
youknowone wants to merge 1 commit intoTextualize:masterfrom
Conversation
1 task
Member
|
It does mean that it won't work on legacy windows. If RustPython only works on more modern Windows, then that might be an acceptable solution. Although I think I would prefer a more explicit check. i.e. Check for RustPython rather than the absence of ctypes. Is that possible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
Description
Hello, I am a developer of RustPython project. RustPython currently doesn't have ctypes, but trying to support pip.
rich is currently bundled in pip. When pip is trying to use rich on legacy windows terminal, it requires ctypes and raising error.
This patch changes rich not to turn on legacy windows terminal supports when ctypes is not available.
Could you check if this is an acceptable approach for rich? Then I will add a test to prevent regressions.